New_REP_SYSTEM/ERP-core
8
0
Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Stop the GL account-code check from being able to abort startup #106

Merged
ImanThiyanga merged 2 commits from Dev into production 2026-10-07 12:10:46 +05:30
Conversation 0 Commits 2 Files Changed 3
+33 -7
ImanThiyanga commented 2026-10-07 12:10:37 +05:30
Owner
Copy Link
Copy Source

The catch filter only matched DomainException/OperationCanceledException,
so anything else escaped a hosted service and took the host down. One such
path was mine: "items": null deserializes over the property initialiser,
so data.Items.Select(...) would NullReferenceException straight past the
filter.

Fixed at both ends - the reader tolerates a null or absent items array, and
the catch is now a deliberate catch-all that only lets a genuine host
shutdown through. This is a diagnostic; a diagnostic that can core-dump the
thing it diagnoses is worse than no diagnostic at all.

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

The catch filter only matched DomainException/OperationCanceledException, so anything else escaped a hosted service and took the host down. One such path was mine: `"items": null` deserializes over the property initialiser, so `data.Items.Select(...)` would NullReferenceException straight past the filter. Fixed at both ends - the reader tolerates a null or absent items array, and the catch is now a deliberate catch-all that only lets a genuine host shutdown through. This is a diagnostic; a diagnostic that can core-dump the thing it diagnoses is worse than no diagnostic at all. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ImanThiyanga added 1 commit 2026-10-07 12:10:37 +05:30
Stop the GL account-code check from being able to abort startup 3c8837e21e 
The catch filter only matched DomainException/OperationCanceledException,
so anything else escaped a hosted service and took the host down. One such
path was mine: `"items": null` deserializes over the property initialiser,
so `data.Items.Select(...)` would NullReferenceException straight past the
filter.

Fixed at both ends - the reader tolerates a null or absent items array, and
the catch is now a deliberate catch-all that only lets a genuine host
shutdown through. This is a diagnostic; a diagnostic that can core-dump the
thing it diagnoses is worse than no diagnostic at all.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ImanThiyanga added 1 commit 2026-10-07 12:10:42 +05:30
Merge branch 'production' into Dev
CI/CD - ERP Core Monorepo / Build & Deploy Frontend (pull_request) Failing after 11m15s
Details
CI/CD - ERP Core Monorepo / Build & Deploy Backend (pull_request) Failing after 12m33s
Details
65976c5cd3
ImanThiyanga merged commit 60652d611e into production 2026-10-07 12:10:46 +05:30
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ashan_rusiru DeepnaPooja HarithaRandunu ImanThiyanga kalana_Thilakarathna Naveen Sasanka
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: New_REP_SYSTEM/ERP-core#106
Delete Branch "Dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?