Make the GL account-code check report instead of refusing to start #105

Merged
ImanThiyanga merged 2 commits from Dev into production 2026-10-07 11:44:37 +05:30
Owner

The check shipped in f753cae threw on a missing code, which core-dumped
erpcore.service on deploy: 11 of the 12 configured Gl*Code values turned
out never to have existed in GL's chart of accounts, so a long-standing
mismatch became an immediate outage.

Detection was the point; refusing to serve the rest of the app was not.
GL already rejects a posting to an unknown account, so the per-flow error
stays the real enforcement — this now logs the whole set at Error once at
boot instead of surfacing one flow at a time.

Hard-fail is still available behind
GeneralLedgerService:FailOnMissingAccountCodes, for once the chart of
accounts is known-good and drift should stop a deploy.

The check shipped in f753cae threw on a missing code, which core-dumped erpcore.service on deploy: 11 of the 12 configured Gl*Code values turned out never to have existed in GL's chart of accounts, so a long-standing mismatch became an immediate outage. Detection was the point; refusing to serve the rest of the app was not. GL already rejects a posting to an unknown account, so the per-flow error stays the real enforcement — this now logs the whole set at Error once at boot instead of surfacing one flow at a time. Hard-fail is still available behind GeneralLedgerService:FailOnMissingAccountCodes, for once the chart of accounts is known-good and drift should stop a deploy.
ImanThiyanga added 1 commit 2026-10-07 11:44:25 +05:30
The check shipped in f753cae threw on a missing code, which core-dumped
erpcore.service on deploy: 11 of the 12 configured Gl*Code values turned
out never to have existed in GL's chart of accounts, so a long-standing
mismatch became an immediate outage.

Detection was the point; refusing to serve the rest of the app was not.
GL already rejects a posting to an unknown account, so the per-flow error
stays the real enforcement — this now logs the whole set at Error once at
boot instead of surfacing one flow at a time.

Hard-fail is still available behind
GeneralLedgerService:FailOnMissingAccountCodes, for once the chart of
accounts is known-good and drift should stop a deploy.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ImanThiyanga added 1 commit 2026-10-07 11:44:30 +05:30
Merge branch 'production' into Dev
CI/CD - ERP Core Monorepo / Build & Deploy Frontend (pull_request) Failing after 12m25s
CI/CD - ERP Core Monorepo / Build & Deploy Backend (pull_request) Failing after 13m43s
e0601d5a8d
ImanThiyanga merged commit 63c8c8457f into production 2026-10-07 11:44:37 +05:30
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: New_REP_SYSTEM/ERP-core#105